ref(preprod): Standardize logging key to preprod_artifact_id#115462
Merged
NicoHinderling merged 4 commits intoMay 13, 2026
Conversation
github-actions
Bot
added
the
Scope: Backend
rbro112
approved these changes
May 13, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 99ac26f. Configure here.
Logging and SDK tags inconsistently used both `artifact_id` and `preprod_artifact_id` across preprod code, making it harder to search and filter logs in Sentry. Standardizes all logging extra fields, SDK tags, and test assertions to use `preprod_artifact_id`. API parameter definitions (`name="artifact_id"`) are left unchanged since they are URL/query parameters, not observability keys.
… contracts The previous commit renamed `artifact_id` to `preprod_artifact_id` in logging extras but also inadvertently changed apply_async kwargs, API response dict keys, and event tags. Revert those non-logging changes to keep task signatures, API contracts, and tag names intact. Co-Authored-By: Claude <noreply@anthropic.com>
The previous revert was too broad — _artifact_to_tags() produces observability/SDK tags, not API response keys. Restore the rename to align with the test assertion and the PR's standardization goal.
…t_id The tag key rename in _artifact_to_tags propagates through head./base. prefixed occurrence tags. Update all downstream test assertions to match.
NicoHinderling
force-pushed
the
nico/standardize-preprod-artifact-id-logging
branch
from
9d20200 to
4b0c790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging and SDK tags inconsistently used both
artifact_idandpreprod_artifact_idacross preprod code, making it difficult to search and filter logs in Sentry (you'd have to query for both key names to find all logs for a given artifact).This standardizes all logging extra fields, SDK tags, and test assertions to use
preprod_artifact_id, which is more specific and avoids ambiguity with other artifact concepts in Sentry (release artifacts, debug artifacts, etc.).API parameter definitions (
name="artifact_id") are left unchanged since they are URL/query parameters, not observability keys.Companion PR in launchpad: getsentry/launchpad#620